[core] Fix FallbackReadScan to handle subset partition keys in fallback branch#7508
Open
lilei1128 wants to merge 3 commits intoapache:masterfrom
Open
[core] Fix FallbackReadScan to handle subset partition keys in fallback branch#7508lilei1128 wants to merge 3 commits intoapache:masterfrom
lilei1128 wants to merge 3 commits intoapache:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
When the fallback branch has fewer partition keys than the main branch
(e.g. main has (dt, a) while fallback has (dt) only), two bugs caused
incorrect query results:
Extra partition key predicates (e.g. a=xxx) were pushed to the
fallback scan unchanged, causing wrong partition filtering.
Partition ownership comparison in plan() used BinaryRow equality
between main's multi-field rows and fallback's single-field rows,
which never matched, so fallback partitions were never recognized
as covered by main.
Close #7503
Tests
CI